Skip to content

feat(pubsub): add support for schema revisions #7295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 26, 2023
Merged

feat(pubsub): add support for schema revisions #7295

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1c145e2
feat(pubsub): add support for schema revisions
hongalex Jan 24, 2023
9f6d2d5
update comments
hongalex Jan 24, 2023
c32ce22
make ListSchemaRevisions in fake more efficient
hongalex Jan 25, 2023
65f399b
fix failing tests related to revisionID being populated
hongalex Jan 25, 2023
40476c2
Merge branch 'main' into pubsub-schema-revision
hongalex Jan 25, 2023
9eb7481
fix conversion of SchemaSettings to proto
hongalex Jan 25, 2023
5ea7516
support GetSchema with revision id
hongalex Jan 25, 2023
ca0303b
support editing schemas in topic update
hongalex Jan 25, 2023
230a0ea
add tests for updating topic with schema
hongalex Jan 26, 2023
6a527ba
Merge branch 'main' into pubsub-schema-revision
hongalex Jan 26, 2023
309022d
Merge branch 'main' into pubsub-schema-revision
hongalex Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing tests related to revisionID being populated
  • Loading branch information
@hongalex
hongalex committed Jan 25, 2023
commit 65f399b143621b3b5ad60a1fe09c267f2c082fc4
14 changes: 10 additions & 4 deletions pubsub/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,19 @@ func TestSchemaBasicCreateGetDelete(t *testing.T) {
admin, _ := newSchemaFake(t)
defer admin.Close()

if gotConfig, err := admin.CreateSchema(ctx, schemaID, schemaConfig); err != nil {
t.Errorf("CreateSchema() got err: %v", err)
} else if diff := cmp.Diff(*gotConfig, schemaConfig); diff != "" {
gotConfig, err := admin.CreateSchema(ctx, schemaID, schemaConfig)
if err != nil {
t.Fatalf("CreateSchema() got err: %v", err)
}
// Don't compare revisionID / create time since that isn't known
// until after it is created.
schemaConfig.RevisionID = gotConfig.RevisionID
schemaConfig.RevisionCreateTime = gotConfig.RevisionCreateTime
if diff := cmp.Diff(*gotConfig, schemaConfig); diff != "" {
t.Errorf("CreateSchema() -want, +got: %v", diff)
}

gotConfig, err := admin.Schema(ctx, schemaID, SchemaViewFull)
gotConfig, err = admin.Schema(ctx, schemaID, SchemaViewFull)
if err != nil {
t.Errorf("Schema() got err: %v", err)
}
Expand Down