Bash script not running as expected

Question

I'm trying to get the script below to take the connection uuid passed to it (by networkmanager), compare it against a list of uuids for my home connections (both physical and VPN) and run certain commands. However, the script appears to go to the "else" clause all the time, even though the uuid is correct.

#!/bin/bash

echo $CONNECTION_UUID

Home_UUIDs="5b509e73-8f08-475c-a14d-7037f2f4b87a ba36c69e-c3f1-4480-a484-1eea105311b2 f3889052-719f-4b88-8b94-e1fa189d44f9"

if [[ "$Home_UUIDs" == *"$CONNECTION_UUID"* ]]; then
        case "$2" in
                up)
                echo "Conecting to Home netork..."
                ntpdate -vs 192.168.0.18
                service ntp start
                ;;
                down)
                echo "Disconnecting from home network"
                service ntp stop
                ;;
        esac
else
        echo "We're not at home..."
        service ntp stop
fi

exit 0

first of all...where is the value of $CONNECTION_UUID coming from? I don't see it being set. — dave_alcarin
– dave_alcarin, Commented Nov 3, 2015 at 13:41
I don't understand why you put stars (*) around $CONNECTION_UUID, can you explain? thx — lese
– lese, Commented Nov 3, 2015 at 13:41
@dave_alcarin It's set by NetworkManager when is is run, along with the value of $2. I've already checked that the UUID is passed correctly. — tmac1
– tmac1, Commented Nov 3, 2015 at 13:43
You are comparing a string against a list of strings. The string is never going to be equal to the list, even if it is part of it. You want to check if your UUID is in the list, not if it is equal. — dave_alcarin
– dave_alcarin, Commented Nov 3, 2015 at 13:45

choroba · Accepted Answer · 2015-11-03 14:00:00Z

It seems to work for me for all three uuids:

#!/bin/bash
Home_UUIDs='5b509e73-8f08-475c-a14d-7037f2f4b87a ba36c69e-c3f1-4480-a484-1eea105311b2 f3889052-719f-4b88-8b94-e1fa189d44f9'

for CONNECTION_UUID in 5b509e73-8f08-475c-a14d-7037f2f4b87a \
                       ba36c69e-c3f1-4480-a484-1eea105311b2 \
                       f3889052-719f-4b88-8b94-e1fa189d44f9 ; do

    if [[ "$Home_UUIDs" == *"$CONNECTION_UUID"* ]]; then
        echo "We're at home!"
    else
        echo "We're not at home..."
    fi
done

Are there any other characters in $CONNECTION_UUID?

tmac1 · Accepted Answer · 2015-11-03 18:09:38Z

0

Finally fixed it by replacing the statement in brackets with

[[ "$Home_UUIDs" =~ "$CONNECTION_UUID" ]]

instead of

[[ "$Home_UUIDs" == *"$CONNECTION_UUID"* ]]

answered Nov 3, 2015 at 18:09

tmac1

396 bronze badges

Add a comment |

Stack Exchange Network

Bash script not running as expected

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Bash script not running as expected

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions