comparing array of strings to one string in android?

Question

when clicking on the button it does nothing ,,,after testing I concluded the problem is with the equal method statment ,,,the whole issue is when comparing string array to string any solutions?

EditText coderead = (EditText)findViewById(R.id.editText1);
        Button   go       = (Button)findViewById(R.id.button1); 
        final String mn=coderead.getText().toString();          
            final String code[] = {"m1","n2"};
            final double pointx[] ={23.666666,65.22222};
            final double pointy[] ={31.55555,29.665544};

        go.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent transfercode = new Intent(getApplicationContext(), FeenbezabtActivity.class);

                for (int i=0; i<code.length; i++) {
                    if(code[i].equals(mn)) {
                        transfercode.putExtra("lat2", pointx[i]);
                        transfercode.putExtra("long", pointy[i]);
                    startActivity(transfercode);
                    }

                    else{Toast.makeText(getBaseContext(), "code not found", 5000);}
                }
            }
        });

Have you tried printing the value of mn to see what it is you are trying to compare? — DaveJohnston
– DaveJohnston, Commented Dec 20, 2011 at 17:15
If your onClick is really invoked then it's supposed to something since got both if and else (one of them should execute). Right? — Bhesh Gurung
– Bhesh Gurung, Commented Dec 20, 2011 at 17:22
@DaveJohnston it forwords to the transfer code activity when i dismiss the equals — Ti7a
– Ti7a, Commented Dec 20, 2011 at 17:22
@user1015086 That wasn't his question, his was "are you comparing the values you think you are". — Dave Newton
– Dave Newton, Commented Dec 20, 2011 at 17:24
@user1015086 what I meant was you should add a statement to your code to print the values of code[i] and mn to the console or file or wherever you are doing your logging and then you will see if the values are what you expect them to be (a very basic debugging technique). — DaveJohnston
– DaveJohnston, Commented Dec 21, 2011 at 10:11

Marcelo · Accepted Answer · 2011-12-20 17:30:47Z

2

Your mn variable should be read after your button has been clicked.

Button go  = (Button) findViewById(R.id.button1); 
final String code[] = {"m1", "n2"};
final double pointx[] = {23.666666, 65.22222};
final double pointy[] = {31.55555, 29.665544};

go.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        Intent transfercode = new Intent(getApplicationContext(), FeenbezabtActivity.class);

        // mn should be read after the button click!
        EditText coderead = (EditText) findViewById(R.id.editText1);
        final String mn = coderead.getText().toString();          

        for (int i = 0; i < code.length; i++) {
            if (code[i].equals(mn)) {
                transfercode.putExtra("lat2", pointx[i]);
                transfercode.putExtra("long", pointy[i]);
                startActivity(transfercode);
            } else {
                Toast.makeText(getBaseContext(), "code not found", 5000);
            }
        }
    }
});

answered Dec 20, 2011 at 17:30

Marcelo

11.3k1 gold badge40 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ti7a Over a year ago

@DaveJohnston i didnt understand the meaning of printing,,,,it's more clear saying invoke ....wat do u think?

Dave Newton Over a year ago

@user1015086 His suggestion was to see if you were comparing the value against what you thought you were, and when--once you realized you weren't comparing it to the current value of the text box, it would have been much easier to track down. His answer (before this one) also correctly identified the issue. Btw, consider using something other than the default IDs for yur resources.

DaveJohnston · Accepted Answer · 2011-12-20 17:28:21Z

1

So if I understand your code correctly you are trying to respond to a button click and take the text that has been input and do something based on that?

You are setting the value of mn at the time you are creating the button, rather than when the button is pressed. At that time the text will be empty (or null). You should move the code to get the value of the entered text to within the onClickListener.

answered Dec 20, 2011 at 17:28

DaveJohnston

10.2k10 gold badges58 silver badges84 bronze badges

Comments

ewan.chalmers · Accepted Answer · 2011-12-20 17:25:24Z

0

Should your "code not found" message happen outside the for loop?

answered Dec 20, 2011 at 17:25

ewan.chalmers

16.3k47 silver badges62 bronze badges

2 Comments

Ti7a Over a year ago

it's about the system code means the input code from the previous activity

ewan.chalmers Over a year ago

Do you want to do that makeText for each iteration of your loop (what you currently have) or only if you exit the loop without finding a match?

Adel Boutros · Accepted Answer · 2011-12-20 17:25:34Z

0

What do you mean by nothing happens? Do you get a Toast message or not? Did you make sure that no error is being generated? If you are not getting the Toast Message and you have no errors, then make sure the intent is correct. I would recommend you debug the code from the line of
Intent transfercode = new Intent(getApplicationContext(), FeenbezabtActivity.class);
Then, report what is happening back here.

answered Dec 20, 2011 at 17:25

Adel Boutros

10.3k8 gold badges58 silver badges91 bronze badges

1 Comment

Ti7a Over a year ago

when // to the line of equals compare ..... it proceeds to the feenbezabtActivity!

Hot Licks · Accepted Answer · 2011-12-20 17:31:06Z

0

Something I don't get. With these two lines:

    final String mn=coderead.getText().toString();          
        final String code[] = {"m1","n2"};

Why don't you just compute the (final) index to code right then and there, vs waiting until onClick?

answered Dec 20, 2011 at 17:31

Hot Licks

47.8k19 gold badges96 silver badges156 bronze badges

1 Comment

Ti7a Over a year ago

the code when is placed in on click ,,,,ide asks for turning those to final:D

Collectives™ on Stack Overflow

comparing array of strings to one string in android?

5 Answers 5

2 Comments

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related